Tidied up breadcrumbs file #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
approved these changes
Feb 23, 2023
Comment on lines
-33
to
-35
| {% if theme_pytorch_project == 'tutorials' %} | ||
| Tutorials | ||
| {% else %} |
There was a problem hiding this comment.
I believe this was a holdover from when the Tutorials were built using a separate process from the main package? Or it's possible it was just copied over from pytorch, because I don't remember seeing the theme_pytorch_project variable anywhere in our codebases.
HuangJunye
reviewed
Feb 27, 2023
There was a problem hiding this comment.
Thanks for cleaning up the breadcrumbs! While I like that the button got removed, I prefer the spacing above and below the breadcrumb before the change. Not sure if this is related to solving the issue of long breadcrumb you mentioned in the description. It would be great if we can solve that issue while still maintain the spacing.
Before
After
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #114
In this PR:
sphinx.ext.linkcodeso that source code links to GitHub #186 ) for further work on improving the source code linksbefore:
after:
